backend/devices: remove feature to get randomness from bb01

Reduce maintenance burden and locize costs.

Author: benma

backend/devices/bitbox/device.go

@@ -790,42 +790,6 @@ func (dbb *Device) Reset(pin string) (bool, error) {
 	return true, nil
 }
 
-// Random generates a 16 byte random number, hex encoded. typ can be either "true" or "pseudo".
-func (dbb *Device) Random(typ string) (string, error) {
-	if dbb.bootloaderStatus != nil {
-		return "", errp.WithStack(errNoBootloader)
-	}
-	if typ != "true" && typ != "pseudo" {
-		dbb.log.WithField("type", typ).Panic("Type must be 'true' or 'pseudo'")
-	}
-	reply, err := dbb.sendKV("random", typ, dbb.pin)
-	if err != nil {
-		return "", errp.WithMessage(err, "Failed to generate random")
-	}
-	rand, ok := reply["random"].(string)
-	if !ok {
-		dbb.log.Error("Unexpected reply: field 'random' is missing")
-		return "", errp.New("unexpected reply")
-	}
-	dbb.log.WithField("random", rand).Debug("Generated random")
-	if len(rand) != 32 {
-		dbb.log.WithField("random-length", len(rand)).Error("Unexpected length: expected 32 bytes")
-		return "", fmt.Errorf("unexpected length, expected 32, got %d", len(rand))
-	}
-
-	if dbb.channel != nil {
-		echo, ok := reply["echo"].(string)
-		if !ok {
-			return "", errp.WithMessage(err, "The random number echo from the BitBox was invalid.")
-		}
-		if err = dbb.channel.SendRandomNumberEcho(echo); err != nil {
-			return "", errp.WithMessage(err, "Could not send the random number echo to the mobile.")
-		}
-	}
-
-	return rand, nil
-}
-
 // BackupList returns a list of backup filenames.
 func (dbb *Device) BackupList() ([]map[string]string, error) {
 	if dbb.bootloaderStatus != nil {

backend/devices/bitbox/handlers/handlers.go

@@ -36,7 +36,6 @@ type Bitbox interface {
 	CreateWallet(string, string) error
 	Login(string) (bool, string, error)
 	Blink() error
-	Random(string) (string, error)
 	Reset(string) (bool, error)
 	UnlockBootloader() (bool, error)
 	LockBootloader() error
@@ -76,7 +75,6 @@ func NewHandlers(
 	handleFunc("/create-wallet", handlers.postCreateWalletHandler).Methods("POST")
 	handleFunc("/backups/list", handlers.getBackupListHandler).Methods("GET")
 	handleFunc("/blink", handlers.postBlinkDeviceHandler).Methods("POST")
-	handleFunc("/random-number", handlers.postGetRandomNumberHandler).Methods("POST")
 	handleFunc("/reset", handlers.postResetDeviceHandler).Methods("POST")
 	handleFunc("/login", handlers.postLoginHandler).Methods("POST")
 	handleFunc("/lock-bootloader", handlers.postLockBootloaderHandler).Methods("POST")
@@ -306,11 +304,6 @@ func (handlers *Handlers) postBlinkDeviceHandler(_ *http.Request) (interface{},
 	return nil, handlers.bitbox.Blink()
 }
 
-func (handlers *Handlers) postGetRandomNumberHandler(_ *http.Request) (interface{}, error) {
-	handlers.log.Debug("Random Number")
-	return handlers.bitbox.Random("true")
-}
-
 func (handlers *Handlers) postResetDeviceHandler(r *http.Request) (interface{}, error) {
 	handlers.log.Debug("Reset")
 	jsonBody := map[string]string{}

frontends/web/src/locales/en/app.json

@@ -1478,10 +1478,6 @@
       "paste": "to paste text, enable \"SHOW {{label}}\""
     }
   },
-  "random": {
-    "button": "Generate random number",
-    "description": "Your BitBox generated the following {{bits}}-bit random number:"
-  },
   "receive": {
     "bitsuranceWarning": "This is an insured account, meaning it can only receive to Native Segwit. This is so you don't accidently receive to Wrapped Segwit or Taproot, which are not insured.",
     "changeScriptType": "Change address type",
@@ -1922,4 +1918,4 @@
     "message": "Please connect your BitBox and tap the side to continue.",
     "title": "Welcome"
   }
-}
+}

frontends/web/src/routes/device/bitbox01/settings/components/randomnumber.jsx

@@ -25,7 +25,6 @@ import { Entry } from '../../../../components/guide/entry';
 import { Header } from '../../../../components/layout';
 import { Spinner } from '../../../../components/spinner/Spinner';
 import Blink from './components/blink';
-import RandomNumber from './components/randomnumber';
 import ChangePIN from './components/changepin';
 import Reset from './components/reset';
 import UpgradeFirmware from '../components/upgradefirmware';
@@ -109,7 +108,6 @@ export const Settings = ({ deviceID }: Props) => {
                     <SettingsItem optionalText={t(`deviceSettings.hardware.sdcard.${sdcard ? 'true' : 'false' }`)}>
                       {t('deviceSettings.hardware.sdcard.label')}
                     </SettingsItem>
-                    <RandomNumber apiPrefix={`devices/${deviceID}`} />
                     <Blink deviceID={deviceID} />
                   </div>
                 </div>