Document and validate paging parameters and behavior #137
Unanswered
ITDancer13
asked this question in
Ideas
Replies: 1 comment
-
I overriden the behaviour of paging as |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I'd suggest to rethink our pagination. At the moment it's a bit confusing having nullable integers on our model with 1...int.MaxValue restrictions which are never checked. Additionally we have default values as configuration option and internal logic like
if (pageSize <= 0)
paging will not be applied.My suggestion for version 3 would be to define and document the following restrictions:
PageSize
andDefaultPageSize
: 0...int.MaxValue with 0 = paging disabledPage
: 1...int.MaxValueIf invalid values are passed to
SieveProcessor.ApplyPagination
an specific exception should be thrown.Beta Was this translation helpful? Give feedback.
All reactions