Skip to content

Conversation

@ieaves
Copy link

@ieaves ieaves commented Dec 4, 2025

Title

Adds formal type validation for a variety of general_settings loaded from config.

Relevant issues

Fixes #17505

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

There are four failing unit tests when I run make test-unit, however, those same four tests appear to fail when running tests on the main branch and I don't believe them to be related to this PR.

Screenshot 2025-12-04 at 5 32 55 PM

Type

🐛 Bug Fix
🧹 Refactoring

Changes

  • Adds various general_settings fields referenced from the general_settings dict in proxy to the typed ConfigGeneralSettings
  • Spoofs dict access patterns on pydantic config settings for backwards compatibility with the previous dict implementation.
  • Pushes general_settings dict through config loading to enforce type validation on load.

@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
litellm Ready Ready Preview Comment Dec 5, 2025 0:04am

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Proxy config accepts proxy_batch_write_at string and crashes APScheduler with TypeError

2 participants