Fix tag management to preserve encrypted fields in litellm_params #17484
+232
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _add_tag_to_deployment function was directly modifying the deployment's litellm_params in memory and writing it back to the database, which caused encrypted API keys and other sensitive fields to be lost. This fix retrieves the model from the database first, preserves all existing fields including encrypted ones, adds only the new tag to the tags array, and updates the database with the modified params while keeping encrypted fields intact. Added comprehensive unit tests covering preservation of encrypted fields, handling of both string and dict litellm_params formats, duplicate tag prevention, and error handling for missing models. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix tag management to preserve encrypted fields in litellm_params
Relevant issues
None previously filed that I could find.
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
The _add_tag_to_deployment function was directly modifying the deployment's litellm_params in memory and writing it back to the database, which caused encrypted API keys and other sensitive fields to be lost. This fix retrieves the model from the database first, preserves all existing fields including encrypted ones, adds only the new tag to the tags array, and updates the database with the modified params while keeping encrypted fields intact.
Added comprehensive unit tests covering preservation of encrypted fields, handling of both string and dict litellm_params formats, duplicate tag prevention, and error handling for missing models.