From 32b2b0380e0594b59fd5fcf3b10015be7433bf8b Mon Sep 17 00:00:00 2001 From: kirill <63228361+kirill-21@users.noreply.github.com> Date: Fri, 27 Sep 2024 10:17:14 -0700 Subject: [PATCH 1/4] Update permission_handler_windows_plugin.cpp Fixed https://github.com/Baseflow/flutter-permission-handler/issues/1388 --- .../windows/permission_handler_windows_plugin.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/permission_handler_windows/windows/permission_handler_windows_plugin.cpp b/permission_handler_windows/windows/permission_handler_windows_plugin.cpp index 4b4d6d184..778ee65cf 100644 --- a/permission_handler_windows/windows/permission_handler_windows_plugin.cpp +++ b/permission_handler_windows/windows/permission_handler_windows_plugin.cpp @@ -87,10 +87,14 @@ void PermissionHandlerWindowsPlugin::RegisterWithRegistrar( } PermissionHandlerWindowsPlugin::PermissionHandlerWindowsPlugin(){ - m_positionChangedRevoker = geolocator.PositionChanged(winrt::auto_revoke, - [this](Geolocator const& geolocator, PositionChangedEventArgs e) - { - }); + try { + m_positionChangedRevoker = geolocator.PositionChanged(winrt::auto_revoke, + [this](Geolocator const& geolocator, PositionChangedEventArgs e) + { + }); + } catch (...) { + /* Do nothing */ + } } PermissionHandlerWindowsPlugin::~PermissionHandlerWindowsPlugin() = default; From 248e9d9516aaee81f1928b72dda95a8bfdabfb20 Mon Sep 17 00:00:00 2001 From: kirill <63228361+kirill-21@users.noreply.github.com> Date: Fri, 27 Sep 2024 10:17:56 -0700 Subject: [PATCH 2/4] Update pubspec.yaml Bumped version --- permission_handler_windows/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/permission_handler_windows/pubspec.yaml b/permission_handler_windows/pubspec.yaml index f5553e0d6..3495a07b7 100644 --- a/permission_handler_windows/pubspec.yaml +++ b/permission_handler_windows/pubspec.yaml @@ -1,6 +1,6 @@ name: permission_handler_windows description: Permission plugin for Flutter. This plugin provides the Windows API to request and check permissions. -version: 0.2.1 +version: 0.2.2 homepage: https://github.com/baseflow/flutter-permission-handler flutter: From 8a74cc8d7a43617a142a545fa1be9272f83f742d Mon Sep 17 00:00:00 2001 From: kirill <63228361+kirill-21@users.noreply.github.com> Date: Fri, 27 Sep 2024 10:18:38 -0700 Subject: [PATCH 3/4] Update CHANGELOG.md --- permission_handler_windows/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/permission_handler_windows/CHANGELOG.md b/permission_handler_windows/CHANGELOG.md index 91c2f5049..88a17aa4e 100644 --- a/permission_handler_windows/CHANGELOG.md +++ b/permission_handler_windows/CHANGELOG.md @@ -1,3 +1,6 @@ +## 0.2.2 +* Fixed crashing issue on early windows 10 machines (https://github.com/Baseflow/flutter-permission-handler/issues/1388) + ## 0.2.1 * Updates the dependency on `permission_handler_platform_interface` to version 4.1.0 (SiriKit support is only available for iOS and macOS). From d6a60b025d00895e5ab47bc240390b7cd38631ea Mon Sep 17 00:00:00 2001 From: kirill <63228361+kirill-21@users.noreply.github.com> Date: Fri, 27 Sep 2024 11:26:54 -0700 Subject: [PATCH 4/4] Update permission_handler_windows_plugin.cpp --- .../windows/permission_handler_windows_plugin.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/permission_handler_windows/windows/permission_handler_windows_plugin.cpp b/permission_handler_windows/windows/permission_handler_windows_plugin.cpp index 778ee65cf..dc6842b49 100644 --- a/permission_handler_windows/windows/permission_handler_windows_plugin.cpp +++ b/permission_handler_windows/windows/permission_handler_windows_plugin.cpp @@ -191,7 +191,11 @@ winrt::fire_and_forget PermissionHandlerWindowsPlugin::IsBluetoothServiceEnabled void PermissionHandlerWindowsPluginRegisterWithRegistrar( FlutterDesktopPluginRegistrarRef registrar) { - PermissionHandlerWindowsPlugin::RegisterWithRegistrar( + try { + PermissionHandlerWindowsPlugin::RegisterWithRegistrar( PluginRegistrarManager::GetInstance() ->GetRegistrar(registrar)); + } catch (...) { + /* Do nothing */ + } }