Make benchmark tool record multiple attribute record separately, Fixes AB#3429544 #2815
+143
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpdome
added
the
No-Changelog
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
rpdome
changed the title
|
✅ Work item link check complete. Description contains link AB#3429544 to an Azure Boards work item. |
github-actions
bot
changed the title
Copilot finished reviewing on behalf of
rpdome
November 17, 2025 17:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in the benchmark tool where only the first occurrence of duplicate status names was being recorded. The fix introduces logic to track and enumerate each occurrence separately (e.g., "status [1]", "status [2]"), enabling proper statistical analysis of repeated status events within spans.
- Refactored the
calculateStatisticsmethod to track occurrence indices for duplicate status names - Added enumeration to display names when multiple occurrences of the same status are detected
- Updated documentation to reflect the new duplicate-tracking behavior
...n4j/src/main/com/microsoft/identity/common/java/opentelemetry/DefaultBenchmarkSpanPrinter.kt
Outdated
Show resolved
Hide resolved
...n4j/src/main/com/microsoft/identity/common/java/opentelemetry/DefaultBenchmarkSpanPrinter.kt
Outdated
Show resolved
Hide resolved
…etry/DefaultBenchmarkSpanPrinter.kt Co-authored-by: Copilot <[email protected]>
rpdome
force-pushed
the
rapong/toolFix
branch
from
145560b to
bc46512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#3429544
Previously, the tool would only record the first occurence of each attributes.