Skip to content

Conversation

@zubairabid
Copy link
Contributor


PR #9834 introduced a bug where AKS customers trying to initialize a restore object would be unable to due to faulty if-condition branching. Fix for that.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 27, 2025 14:05
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 27, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @zubairabid,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 27, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This hotfix addresses a critical regression introduced in PR #9834 that prevented AKS customers from initializing restore objects due to incorrect control flow branching.

Key Changes:

  • Added early return for AKS restore criteria processing to prevent execution of blob-specific logic
  • Fixed indentation of blob-specific processing logic to properly scope it within the else block

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 27, 2025

Please fix CI issues

@zubairabid
Copy link
Contributor Author

Please fix CI issues

@yonzhan I've fixed these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants