Getting default flag for versions (#4466)

* Getting default flag for versions

* Tests update

Author: sankur-codes

pkg/api/admin/openshiftversion.go

@@ -30,4 +30,5 @@ type OpenShiftVersionProperties struct {
 	OpenShiftPullspec string `json:"openShiftPullspec,omitempty" mutable:"true"`
 	InstallerPullspec string `json:"installerPullspec,omitempty" mutable:"true"`
 	Enabled           bool   `json:"enabled" mutable:"true"`
+	Default           bool   `json:"default" mutable:"true"`
 }

pkg/api/admin/openshiftversion_convert.go

@@ -21,6 +21,7 @@ func (openShiftVersionConverter) ToExternal(v *api.OpenShiftVersion) interface{}
 			OpenShiftPullspec: v.Properties.OpenShiftPullspec,
 			InstallerPullspec: v.Properties.InstallerPullspec,
 			Enabled:           v.Properties.Enabled,
+			Default:           v.Properties.Default,
 		},
 		Name: v.Name,
 		Type: v.Type,
@@ -62,6 +63,7 @@ func (c openShiftVersionConverter) ToInternal(_new interface{}, out *api.OpenShi
 	out.Properties.InstallerPullspec = new.Properties.InstallerPullspec
 	out.Properties.OpenShiftPullspec = new.Properties.OpenShiftPullspec
 	out.Properties.Version = new.Properties.Version
+	out.Properties.Default = new.Properties.Default
 	out.Name = new.Properties.Version
 	out.Type = api.OpenShiftVersionsType
 }

pkg/frontend/admin_openshiftversion_list_test.go

@@ -43,6 +43,7 @@ func TestOpenShiftVersionList(t *testing.T) {
 							Properties: api.OpenShiftVersionProperties{
 								Version:           "4.10.0",
 								Enabled:           true,
+								Default:           true,
 								OpenShiftPullspec: "a:a/b",
 							},
 						},
@@ -53,6 +54,7 @@ func TestOpenShiftVersionList(t *testing.T) {
 
 								Version:           "4.9.9",
 								Enabled:           true,
+								Default:           false,
 								OpenShiftPullspec: "a:a/b",
 								InstallerPullspec: "b:b/c",
 							},
@@ -64,6 +66,7 @@ func TestOpenShiftVersionList(t *testing.T) {
 
 								Version:           "4.10.1",
 								Enabled:           false,
+								Default:           false,
 								OpenShiftPullspec: "a:a/b",
 								InstallerPullspec: "b:b/c",
 							},
@@ -78,6 +81,7 @@ func TestOpenShiftVersionList(t *testing.T) {
 						Properties: admin.OpenShiftVersionProperties{
 							Version:           "4.9.9",
 							Enabled:           true,
+							Default:           false,
 							OpenShiftPullspec: "a:a/b",
 							InstallerPullspec: "b:b/c",
 						},
@@ -88,6 +92,7 @@ func TestOpenShiftVersionList(t *testing.T) {
 						Properties: admin.OpenShiftVersionProperties{
 							Version:           "4.10.0",
 							Enabled:           true,
+							Default:           true,
 							OpenShiftPullspec: "a:a/b",
 						},
 						Name: "4.10.0",
@@ -97,6 +102,7 @@ func TestOpenShiftVersionList(t *testing.T) {
 						Properties: admin.OpenShiftVersionProperties{
 							Version:           "4.10.1",
 							Enabled:           false,
+							Default:           false,
 							OpenShiftPullspec: "a:a/b",
 							InstallerPullspec: "b:b/c",
 						},

pkg/frontend/admin_openshiftversion_put_test.go

@@ -37,6 +37,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 							Properties: api.OpenShiftVersionProperties{
 								Version:           "4.10.0",
 								Enabled:           true,
+								Default:           false,
 								OpenShiftPullspec: "a:a/b",
 							},
 						},
@@ -47,6 +48,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 				Properties: admin.OpenShiftVersionProperties{
 					Version:           "4.10.0",
 					Enabled:           false,
+					Default:           false,
 					OpenShiftPullspec: "c:c/d",
 					InstallerPullspec: "d:d/e",
 				},
@@ -58,6 +60,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 				Properties: admin.OpenShiftVersionProperties{
 					Version:           "4.10.0",
 					Enabled:           false,
+					Default:           false,
 					OpenShiftPullspec: "c:c/d",
 					InstallerPullspec: "d:d/e",
 				},
@@ -71,6 +74,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 						Properties: api.OpenShiftVersionProperties{
 							Version:           "4.10.0",
 							Enabled:           false,
+							Default:           false,
 							OpenShiftPullspec: "c:c/d",
 							InstallerPullspec: "d:d/e",
 						},
@@ -89,6 +93,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 							Properties: api.OpenShiftVersionProperties{
 								Version:           "4.15.0",
 								Enabled:           true,
+								Default:           false,
 								OpenShiftPullspec: "a:a/b",
 							},
 							Name: "4.15.0",
@@ -101,6 +106,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 				Properties: admin.OpenShiftVersionProperties{
 					Version:           "4.15.0",
 					Enabled:           false,
+					Default:           false,
 					OpenShiftPullspec: "c:c/d",
 					InstallerPullspec: "d:d/e",
 				},
@@ -112,6 +118,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 				Properties: admin.OpenShiftVersionProperties{
 					Version:           "4.15.0",
 					Enabled:           false,
+					Default:           false,
 					OpenShiftPullspec: "c:c/d",
 					InstallerPullspec: "d:d/e",
 				},
@@ -125,6 +132,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 						Properties: api.OpenShiftVersionProperties{
 							Version:           "4.15.0",
 							Enabled:           false,
+							Default:           false,
 							OpenShiftPullspec: "c:c/d",
 							InstallerPullspec: "d:d/e",
 						},
@@ -143,6 +151,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 							Properties: api.OpenShiftVersionProperties{
 								Version:           "4.10.0",
 								Enabled:           true,
+								Default:           false,
 								OpenShiftPullspec: "a:a/b",
 							},
 						},
@@ -153,6 +162,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 				Properties: admin.OpenShiftVersionProperties{
 					Version:           "4.10.1",
 					Enabled:           true,
+					Default:           false,
 					OpenShiftPullspec: "f:f/g",
 					InstallerPullspec: "g:g/h",
 				},
@@ -162,6 +172,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 				Properties: admin.OpenShiftVersionProperties{
 					Version:           "4.10.1",
 					Enabled:           true,
+					Default:           false,
 					OpenShiftPullspec: "f:f/g",
 					InstallerPullspec: "g:g/h",
 				},
@@ -175,6 +186,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 						Properties: api.OpenShiftVersionProperties{
 							Version:           "4.10.0",
 							Enabled:           true,
+							Default:           false,
 							OpenShiftPullspec: "a:a/b",
 						},
 					},
@@ -185,6 +197,7 @@ func TestOpenShiftVersionPut(t *testing.T) {
 						Properties: api.OpenShiftVersionProperties{
 							Version:           "4.10.1",
 							Enabled:           true,
+							Default:           false,
 							OpenShiftPullspec: "f:f/g",
 							InstallerPullspec: "g:g/h",
 						},