-
Notifications
You must be signed in to change notification settings - Fork 2k
Update magic login footer text to prevent wrapping #107130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
- Changed 'Check your spam folder' to 'Check spam' for better line wrapping - Updated magic code page to use 'Didn't get the code?' (semantically correct) - Updated magic link page to use 'Didn't get the email?' (semantically correct) - Added comma before 'or' for better readability Closes https://linear.app/a8c/issue/DSGCOM-153/login-magic-code-on-confirm-page-update-footer-to-a-tertiary-resend
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
@jasmussen what do you think of the copy change? The goal is to keep the text on two lines (no wrapping), while not expanding beyond the form (or to expand the form itself). There are alternatives:
|
dzver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will make 2 strings untranslated while decreasing the clarity of the message.
The text would be longer in other languages and it would be on 3 or maybe 4 lines anyways.
Indeed, good call. Totally ignored that. Thinking what a better option would be here. It sounds like either going with just a tertiary button "resend code" or expanding the form (which again won't solve it for all translations, and I think it was wider before and we changed / or it was narrower and folks didn't like this wider one) |
|
Thank you for the ping, thank you for the attention to detail. I wonder, can it be one paragraph, instead of two paragraphs? I.e. the present state is this, two paragraphs:
The above is also missing some periods, in general I would always end sentences in periods, that's the most safe rule of thumb. In any case, what I'm proposing could be something like this, one paragraph:
We could rephrase further to optimize things, but Veselin has a solid point as well as far as translations. We need something that, as well as it can, handles longer languages. We should already be applying Yet another alternative would be to keep the two separate paragraphs, but apply
As far as systematization, this would be a bit of an edge-case, applying custom CSS just to this, generally something to minimize, so I'm sharing the above options in case something stands out, or inspires better ideas! |
Thanks @jasmussen. I will go through these and work something out for testing. I am assuming the original proposal by Matt.W. to have a plain tertiary button "Resend code" for the first line, probably closer to the main CTA, we don't want that, right? |
I don't think it's a bad idea. I'm just generally weary around changing around sensitive bits too much, and slightly at random, so often I'm veering towards the simplest solutions to try first. But it can work if all else doesn't! |
Sounds good. We can test both then. :-) |
Closes https://linear.app/a8c/issue/DSGCOM-153/login-magic-code-on-confirm-page-update-footer-to-a-tertiary-resend
Part of https://linear.app/a8c/issue/DSGCOM-153/login-magic-code-on-confirm-page-update-footer-to-a-tertiary-resend
Proposed Changes
Why are these changes being made?
Testing Instructions
/log-in/linkand submit the form with an email address (e.g.,[email protected])/log-in/jetpack/linkand submit the form with an email addressPre-merge Checklist