Skip to content

Conversation

@fushar
Copy link
Contributor

@fushar fushar commented Nov 14, 2025

Proposed Changes

This PR adds persistence to GitHub Deployments' DataViews.

It utilizes the transient filter feature from #107066.

I updated the field name from repository_name to repository because it needs to match with the query param key.

Testing Instructions

From Deployments:

  1. Go to /v2/sites/:siteSlug/deployments.
  2. Try to change page, search term, and appearance options.
  3. Refresh the page.
  4. Verify the view persists.
  5. Click "Reset view".
  6. Verify the view is reset.

From Settings -> repositories:

  1. Go to /v2/sites/:siteSlug/settings/repositories.
  2. Select a row -> click 3-dot action icon -> click "See deployment runs".
  3. Verify you see the DataViews with the primary filter set to the selected repository.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Nov 14, 2025


export const DEFAULT_VIEW: View = {
type: 'table',
perPage: 25,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not one of the default values:

Image

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug deployments-dv-persistence on your sandbox.

@fushar fushar marked this pull request as ready for review November 14, 2025 08:17
@fushar fushar requested a review from a team as a code owner November 14, 2025 08:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2025
@fushar fushar self-assigned this Nov 14, 2025
@fushar fushar requested a review from a team November 14, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants