Skip to content

Conversation

@StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Nov 14, 2025

Related to: #107119
Part of DOTMSD-849, DES-52

Proposed Changes

This PR hides the callout images when on mobile devices.

@p-jackson Led some discussion in #103414 to agree on a mobile approach but no resolution was made. He did suggest hiding the images but noted that its underwhelming.

Since these modals are in production, I think it's wise for us to hide them. The experience is not great in the V1 dashboard as it is. Hiding the image, while underwhelming make the callout more useable while giving us time to align on best approach.

Screenshot

Before After
wpcalypso wordpress com_v2_sites_testoverviewcardstatus1234 wordpress com_backups_back_to=overview(iPhone SE) (1) calypso localhost_3000_v2_sites_testoverviewcardstatus1234 wordpress com_backups_back_to=overview (5)
wpcalypso wordpress com_sites(iPhone SE) calypso localhost_3000_sites_(iPhone SE)

Responsive

Screen Recording on 2025-11-14 at 12-54-13

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2025
@StevenDufresne StevenDufresne marked this pull request as ready for review November 14, 2025 04:04
@StevenDufresne StevenDufresne requested a review from a team as a code owner November 14, 2025 04:04
@StevenDufresne StevenDufresne changed the title Hide image on mobile. MSD: Hide callout image on mobile. Nov 14, 2025
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Agree with this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants