Add support for dispute additional evidence types feature and update related tests

Author: mgascam

includes/class-wc-payments-features.php

@@ -27,6 +27,7 @@ class WC_Payments_Features {
 	const WOOPAY_FIRST_PARTY_AUTH_FLAG_NAME                   = '_wcpay_feature_woopay_first_party_auth';
 	const WOOPAY_DIRECT_CHECKOUT_FLAG_NAME                    = '_wcpay_feature_woopay_direct_checkout';
 	const DISPUTE_ISSUER_EVIDENCE                             = '_wcpay_feature_dispute_issuer_evidence';
+	const DISPUTE_ADDITIONAL_EVIDENCE_TYPES                   = '_wcpay_feature_dispute_additional_evidence_types';
 	const WOOPAY_GLOBAL_THEME_SUPPORT_FLAG_NAME               = '_wcpay_feature_woopay_global_theme_support';
 	const WCPAY_DYNAMIC_CHECKOUT_PLACE_ORDER_BUTTON_FLAG_NAME = '_wcpay_feature_dynamic_checkout_place_order_button';
 	const ACCOUNT_DETAILS_FLAG_NAME                           = '_wcpay_feature_account_details';
@@ -323,6 +324,17 @@ public static function is_dispute_issuer_evidence_enabled(): bool {
 		return '1' === get_option( self::DISPUTE_ISSUER_EVIDENCE, '0' );
 	}
 
+	/**
+	 * Checks whether Dispute Additional Evidence Types feature should be enabled. Disabled by default.
+	 *
+	 * This gates the new evidence form types (event, booking_reservation, other) for dispute challenges.
+	 *
+	 * @return bool
+	 */
+	public static function is_dispute_additional_evidence_types_enabled(): bool {
+		return '1' === get_option( self::DISPUTE_ADDITIONAL_EVIDENCE_TYPES, '0' );
+	}
+
 	/**
 	 * Checks whether the next deposit notice on the deposits list screen has been dismissed.
 	 *
@@ -363,6 +375,7 @@ public static function to_array() {
 				'documents'                                => self::is_documents_section_enabled(),
 				'woopayExpressCheckout'                    => self::is_woopay_express_checkout_enabled(),
 				'isDisputeIssuerEvidenceEnabled'           => self::is_dispute_issuer_evidence_enabled(),
+				'isDisputeAdditionalEvidenceTypesEnabled'  => self::is_dispute_additional_evidence_types_enabled(),
 				'isFRTReviewFeatureActive'                 => self::is_frt_review_feature_active(),
 				'isDynamicCheckoutPlaceOrderButtonEnabled' => self::is_dynamic_checkout_place_order_button_enabled(),
 				'isAccountDetailsEnabled'                  => self::is_account_details_enabled(),

includes/wc-payment-api/class-wc-payments-api-client.php

@@ -3000,8 +3000,8 @@ private function determine_suggested_product_type( WC_Order $order ): string {
 		}
 
 		// At this point, we know there's exactly one product.
-		// Check for specific product types.
-		if ( 'booking' === $product_type ) {
+		// Check for specific product types (gated by feature flag).
+		if ( WC_Payments_Features::is_dispute_additional_evidence_types_enabled() && 'booking' === $product_type ) {
 			return 'booking_reservation';
 		}
 

tests/unit/wc-payment-api/test-class-wc-payments-api-client.php

@@ -1304,7 +1304,10 @@ private function create_woocommerce_default_pages(): array {
 	 *
 	 * @dataProvider data_determine_suggested_product_type
 	 */
-	public function test_determine_suggested_product_type( $order_items, $expected_product_type ) {
+	public function test_determine_suggested_product_type( $order_items, $expected_product_type, $feature_flag_enabled = true ) {
+		// Set the feature flag option.
+		update_option( WC_Payments_Features::DISPUTE_ADDITIONAL_EVIDENCE_TYPES, $feature_flag_enabled ? '1' : '0' );
+
 		// Create a mock order.
 		$mock_order = $this->getMockBuilder( 'WC_Order' )
 			->disableOriginalConstructor()
@@ -1328,75 +1331,92 @@ public function test_determine_suggested_product_type( $order_items, $expected_p
 	 */
 	public function data_determine_suggested_product_type() {
 		return [
-			'empty_order'                  => [
+			'empty_order'                              => [
 				'order_items'           => [],
 				'expected_product_type' => 'physical_product',
 			],
-			'single_physical_product'      => [
+			'single_physical_product'                  => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( false ), // not virtual.
 				],
 				'expected_product_type' => 'physical_product',
 			],
-			'single_virtual_product'       => [
+			'single_virtual_product'                   => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( true ), // virtual.
 				],
 				'expected_product_type' => 'digital_product_or_service',
 			],
-			'multiple_products_mixed'      => [
+			'multiple_products_mixed'                  => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( false ), // physical.
 					$this->create_mock_order_item_product( true ),  // virtual.
 				],
 				'expected_product_type' => 'multiple',
 			],
-			'multiple_physical_products'   => [
+			'multiple_physical_products'               => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( false ), // physical.
 					$this->create_mock_order_item_product( false ), // physical.
 				],
 				'expected_product_type' => 'multiple',
 			],
-			'multiple_virtual_products'    => [
+			'multiple_virtual_products'                => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( true ), // virtual.
 					$this->create_mock_order_item_product( true ), // virtual.
 				],
 				'expected_product_type' => 'multiple',
 			],
-			'order_with_non_product_items' => [
+			'order_with_non_product_items'             => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( true ), // virtual product.
 					$this->create_mock_order_item_shipping(), // shipping item (not a product).
 				],
 				'expected_product_type' => 'digital_product_or_service',
 			],
-			'order_with_invalid_product'   => [
+			'order_with_invalid_product'               => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( true, false ), // virtual but invalid product.
 				],
 				'expected_product_type' => 'physical_product',
 			],
-			'single_booking_product'       => [
+			'single_booking_product'                   => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( true, true, 'booking' ), // booking product.
 				],
 				'expected_product_type' => 'booking_reservation',
+				'feature_flag_enabled'  => true,
+			],
+			'single_booking_product_flag_off'          => [
+				'order_items'           => [
+					$this->create_mock_order_item_product( true, true, 'booking' ), // booking product (virtual).
+				],
+				'expected_product_type' => 'digital_product_or_service', // Falls back to virtual detection.
+				'feature_flag_enabled'  => false,
+			],
+			'single_booking_product_physical_flag_off' => [
+				'order_items'           => [
+					$this->create_mock_order_item_product( false, true, 'booking' ), // booking product (not virtual).
+				],
+				'expected_product_type' => 'physical_product', // Falls back to physical detection.
+				'feature_flag_enabled'  => false,
 			],
-			'multiple_booking_products'    => [
+			'multiple_booking_products'                => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( true, true, 'booking' ), // booking.
 					$this->create_mock_order_item_product( true, true, 'booking' ), // booking.
 				],
 				'expected_product_type' => 'multiple',
+				'feature_flag_enabled'  => true,
 			],
-			'booking_physical_mixed'       => [
+			'booking_physical_mixed'                   => [
 				'order_items'           => [
 					$this->create_mock_order_item_product( true, true, 'booking' ), // booking.
 					$this->create_mock_order_item_product( false, true, 'simple' ), // physical.
 				],
 				'expected_product_type' => 'multiple',
+				'feature_flag_enabled'  => true,
 			],
 		];
 	}