From 7407c8fcfe37f31e47faa021583a0cab8005e56d Mon Sep 17 00:00:00 2001 From: Alex Barnsley <8069294+alexbarnsley@users.noreply.github.com> Date: Tue, 1 Apr 2025 12:58:34 +0100 Subject: [PATCH] refactor: remove unused get bytes transaction method --- crypto/transactions/serializer.py | 4 ---- crypto/transactions/types/abstract_transaction.py | 5 ----- tests/transactions/test_transaction.py | 5 ----- 3 files changed, 14 deletions(-) diff --git a/crypto/transactions/serializer.py b/crypto/transactions/serializer.py index 97a61577..d3e1e2ee 100644 --- a/crypto/transactions/serializer.py +++ b/crypto/transactions/serializer.py @@ -11,10 +11,6 @@ def __init__(self, transaction: AbstractTransaction): def new(transaction: AbstractTransaction): return Serializer(transaction) - @staticmethod - def get_bytes(transaction: AbstractTransaction, skip_signature: bool = False) -> bytes: - return transaction.serialize(skip_signature=skip_signature) - def serialize(self, skip_signature: bool = False) -> bytes: transaction_hash = TransactionUtils.to_buffer(self.transaction.data, skip_signature=skip_signature).decode() diff --git a/crypto/transactions/types/abstract_transaction.py b/crypto/transactions/types/abstract_transaction.py index 02be21b6..2a218f4a 100644 --- a/crypto/transactions/types/abstract_transaction.py +++ b/crypto/transactions/types/abstract_transaction.py @@ -24,11 +24,6 @@ def refresh_payload_data(self): def get_id(self) -> str: return TransactionUtils.get_id(self.data) - def get_bytes(self, skip_signature: bool = False) -> bytes: - from crypto.transactions.serializer import Serializer - - return Serializer.get_bytes(self, skip_signature) - def sign(self, private_key: PrivateKey): transaction_hash = TransactionUtils.to_buffer(self.data, skip_signature=True).decode() diff --git a/tests/transactions/test_transaction.py b/tests/transactions/test_transaction.py index 477348ac..87e9de24 100644 --- a/tests/transactions/test_transaction.py +++ b/tests/transactions/test_transaction.py @@ -27,11 +27,6 @@ def test_verify_transaction(load_transaction_fixture): transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize() assert transaction.verify() -def test_transaction_to_bytes(load_transaction_fixture): - transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize() - actual = transaction.get_bytes() - assert isinstance(actual, bytes) - def test_transaction_to_array(load_transaction_fixture): transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize() actual = transaction.to_dict()