Skip to content

Fixed https://github.com/AppifySheets/TBC-IntegrationService-StandardPlus-Client/issues/20 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petre-c merged 2 commits into from
Oct 1, 2025
Merged

Fixed https://github.com/AppifySheets/TBC-IntegrationService-StandardPlus-Client/issues/20 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e9d173
Fixed https://github.com/AppifySheets/TBC-IntegrationService-Standard…
Oct 1, 2025
f768768
fix: Add PersonalNumber field to TransferWithinBank initializers
Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions AppifySheets.TBC.IntegrationService.Client.DemoConsole/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@
Amount = 0.01m,
BeneficiaryName = "TEST",
SenderAccountWithCurrency = ownAccountGEL,
Description = "TEST",
PersonalNumber = null // Adding required PersonalNumber field
Description = "TEST"
};

var withinBankGel2 = await tbcSoapCaller.GetDeserialized(new ImportSinglePaymentOrdersRequestIo(
new TransferWithinBankPaymentOrderIo
{
RecipientAccountWithCurrency = BankAccount.Create("GE86TB1144836120100002", "GEL").Value,
BankTransferCommonDetails = bankTransferCommonDetails
BankTransferCommonDetails = bankTransferCommonDetails,
PersonalNumber = null
}));

var withinBankCurrency = await tbcSoapCaller.GetDeserialized(new ImportSinglePaymentOrdersRequestIo(
Expand All @@ -52,6 +52,7 @@
SenderAccountWithCurrency = ownAccountUSD
},
RecipientAccountWithCurrency = BankAccount.Create("GE86TB1144836120100002", "USD").Value,
PersonalNumber = null
}));

var toAnotherBankGel = await tbcSoapCaller.GetDeserialized(
Expand Down
2 changes: 1 addition & 1 deletion ...Client/SoapInfrastructure/ImportSinglePaymentOrders/ImportSinglePaymentOrdersRequestIo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public override string SoapXml()
<myg:additionalDescription>{TransferType.AdditionalDescription}</myg:additionalDescription>
{TransferType.Is<IDescription>(b => $"<myg:description>{b.Description}</myg:description>")}
{TransferType.Is<IBeneficiaryName>(b => $"<myg:beneficiaryName>{b.BeneficiaryName}</myg:beneficiaryName>")}
{TransferType.Is<IBeneficiaryName>(b => $"<myg:personalNumber>{b.PersonalNumber}</myg:personalNumber>")}
{TransferType.Is<IPersonalNumber>(b => $"<myg:personalNumber>{b.PersonalNumber}</myg:personalNumber>")}
{TransferType.Is<IBeneficiaryTaxCode>(b => $"<myg:beneficiaryTaxCode>{b.BeneficiaryTaxCode}</myg:beneficiaryTaxCode>")}
{TransferType.Is<IBeneficiaryForCurrencyTransfer>(b
=> $"""
Expand Down
9 changes: 6 additions & 3 deletions ...tionService.Client/SoapInfrastructure/ImportSinglePaymentOrders/TransferTypeInterfaces.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ public sealed record BankTransferCommonDetails
public required long DocumentNumber { get; init; }
public required decimal Amount { get; init; }
public required string BeneficiaryName { get; init; }
public required string? PersonalNumber { get; init; }
public required string Description { get; init; }
public string? AdditionalDescription { get; init; }
}
Expand All @@ -23,17 +22,21 @@ public abstract record TransferTypeRecord
public long DocumentNumber => BankTransferCommonDetails.DocumentNumber;
public decimal Amount => BankTransferCommonDetails.Amount;
public string BeneficiaryName => BankTransferCommonDetails.BeneficiaryName;
public string? PersonalNumber => BankTransferCommonDetails.PersonalNumber;
// public string? PersonalNumber => BankTransferCommonDetails.PersonalNumber;
public string Description => BankTransferCommonDetails.Description;
public string? AdditionalDescription => BankTransferCommonDetails.AdditionalDescription;
}

public interface IBeneficiaryName
{
public string BeneficiaryName { get; }
public string? PersonalNumber { get; }
// public string? PersonalNumber { get; }
}

public interface IPersonalNumber
{
string? PersonalNumber { get; }
}
public interface IDescription
{
public string Description { get; }
Expand Down
3 changes: 2 additions & 1 deletion ...grationService.Client/SoapInfrastructure/ImportSinglePaymentOrders/TransferTypeRecords.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@

namespace AppifySheets.TBC.IntegrationService.Client.SoapInfrastructure.ImportSinglePaymentOrders;

public record TransferWithinBankPaymentOrderIo : TransferTypeRecord, IRecipient, IBeneficiaryName, IDescription
public record TransferWithinBankPaymentOrderIo : TransferTypeRecord, IRecipient, IBeneficiaryName, IDescription, IPersonalNumber
{
public required BankAccount RecipientAccountWithCurrency { get; init; }
public required string? PersonalNumber { get; init; }
}

public record TransferToOtherBankForeignCurrencyPaymentOrderIo(
Expand Down
7 changes: 4 additions & 3 deletions AppifySheets.TBC.IntegrationService.Tests/TBCSoapCallerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,15 @@ public async Task ImportSinglePaymentOrders_returns_values()
Amount = 0.01m,
BeneficiaryName = "TEST",
SenderAccountWithCurrency = ownAccountGEL,
Description = "TEST",
PersonalNumber = null // Adding required PersonalNumber field
Description = "TEST"
};

var withinBankGel2 = await _tbcSoapCaller.GetDeserialized(new ImportSinglePaymentOrdersRequestIo(
new TransferWithinBankPaymentOrderIo
{
RecipientAccountWithCurrency = BankAccount.Create("GE24TB7755145063300001", "GEL").Value,
BankTransferCommonDetails = bankTransferCommonDetails
BankTransferCommonDetails = bankTransferCommonDetails,
PersonalNumber = null
}));

var withinBankCurrency = await _tbcSoapCaller.GetDeserialized(new ImportSinglePaymentOrdersRequestIo(
Expand All @@ -91,6 +91,7 @@ public async Task ImportSinglePaymentOrders_returns_values()
SenderAccountWithCurrency = ownAccountUSD
},
RecipientAccountWithCurrency = BankAccount.Create("GE86TB1144836120100002", "USD").Value,
PersonalNumber = null
}));

var toAnotherBankGel = await _tbcSoapCaller.GetDeserialized(
Expand Down
Loading