#1029: resolve issue with bad memory access in ranged for loop found on Mac OS (clang compiler)

lederernc · lederernc · commit 5901b0bf2c99 · 2025-11-04T18:27:28.000-08:00
diff --git a/CPP/Clipper2Lib/src/clipper.engine.cpp b/CPP/Clipper2Lib/src/clipper.engine.cpp
@@ -2940,9 +2940,10 @@ namespace Clipper2Lib {
 
   bool ClipperBase::CheckSplitOwner(OutRec* outrec, OutRecList* splits)
   {
-    for (auto split : *splits)
+    for (size_t idx = 0; idx < splits->size(); ++idx)
     {
-      if (!split->pts && split->splits &&
+      auto split = (*splits)[idx];
+      if (split && !split->pts && split->splits &&
         CheckSplitOwner(outrec, split->splits)) return true; //#942
       split = GetRealOutRec(split);
       if (!split || split == outrec || split->recursive_split == outrec) continue;

Original file line number	Diff line number	Diff line change
`@@ -2940,9 +2940,10 @@ namespace Clipper2Lib {`
`2940`	`2940`
`2941`	`2941`	`bool ClipperBase::CheckSplitOwner(OutRec* outrec, OutRecList* splits)`
`2942`	`2942`	`{`
`2943`		`- for (auto split : *splits)`
	`2943`	`+ for (size_t idx = 0; idx < splits->size(); ++idx)`
`2944`	`2944`	`{`
`2945`		`- if (!split->pts && split->splits &&`
	`2945`	`+ auto split = (*splits)[idx];`
	`2946`	`+ if (split && !split->pts && split->splits &&`
`2946`	`2947`	`CheckSplitOwner(outrec, split->splits)) return true; //#942`
`2947`	`2948`	`split = GetRealOutRec(split);`
`2948`	`2949`	`if (!split \|\| split == outrec \|\| split->recursive_split == outrec) continue;`