fix(ci): handle npm workspaces partial node_modules (#1404)

* hotfix(build): disable npmRebuild for electron-builder workspace compatibility

electron-builder's @electron/rebuild cannot properly handle symlinked
node_modules directories in npm workspace setups. It fails with:
ENOENT: no such file or directory, stat 'apps/frontend/node_modules'

Setting npmRebuild: false bypasses this issue because:
1. stageRuntimePackages() already copies @lydell/node-pty to out/main/node_modules
2. @lydell/node-pty uses prebuilt binaries - no rebuild needed
3. This skips the problematic @electron/rebuild phase entirely

Fixes macOS Intel, macOS Silicon, and potentially Windows release builds.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(ci): handle npm workspaces partial node_modules blocking symlink

npm workspaces may create a partial node_modules directory in
apps/frontend for packages that couldn't be hoisted. This blocked
the symlink creation because the condition checked if the directory
existed before creating the symlink.

Changes:
- Remove any existing partial node_modules directory (not symlink)
- Only then create the symlink to root node_modules
- Add verification that symlink resolves correctly
- Add detailed logging for debugging

This fixes macOS release builds failing with ENOENT during
@electron/osx-sign code signing phase.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: AndyMik90

.github/actions/setup-node-frontend/action.yml

@@ -55,15 +55,24 @@ runs:
       # With npm workspaces, packages are hoisted to root. Create a link so electron-builder
       # can find the modules during packaging and code signing.
       # Uses symlink on Unix, directory junction on Windows (works without admin privileges).
+      #
+      # IMPORTANT: npm workspaces may create a partial node_modules in apps/frontend for
+      # packages that couldn't be hoisted. We must remove it and create a proper link to root.
       run: |
         # Verify npm ci succeeded
         if [ ! -d "node_modules" ]; then
           echo "::error::Root node_modules does not exist. npm ci may have failed."
           exit 1
         fi
 
-        # Create link if needed
-        if [ ! -d "apps/frontend/node_modules" ] && [ ! -L "apps/frontend/node_modules" ]; then
+        # Remove any existing node_modules in apps/frontend (npm workspaces may create partial one)
+        if [ -d "apps/frontend/node_modules" ] && [ ! -L "apps/frontend/node_modules" ]; then
+          echo "Removing partial node_modules created by npm workspaces..."
+          rm -rf "apps/frontend/node_modules"
+        fi
+
+        # Create link if it doesn't exist
+        if [ ! -L "apps/frontend/node_modules" ]; then
           if [ "$RUNNER_OS" == "Windows" ]; then
             # Use directory junction on Windows (works without admin privileges)
             cmd //c "mklink /J apps\\frontend\\node_modules ..\\..\\node_modules"
@@ -83,5 +92,18 @@ runs:
             fi
           fi
         else
-          echo "apps/frontend/node_modules already exists, skipping"
+          echo "apps/frontend/node_modules symlink already exists"
+        fi
+
+        # Verify the link works
+        if [ -L "apps/frontend/node_modules" ]; then
+          target=$(readlink apps/frontend/node_modules 2>/dev/null || echo "junction")
+          echo "Verified: apps/frontend/node_modules -> $target"
+          # Check that the target resolves correctly
+          if [ -d "apps/frontend/node_modules" ]; then
+            count=$(ls apps/frontend/node_modules 2>/dev/null | wc -l)
+            echo "Link resolves to directory with $count entries"
+          else
+            echo "::warning::Link exists but does not resolve to a valid directory"
+          fi
         fi