fix(tests): address PR review feedback

- Remove unused imports (AsyncMock, patch) from test_spec_complexity.py
- Remove unused MagicMock import from test_spec_pipeline.py
- Move inline 'import os' to module level in test_spec_pipeline.py
- Rename _API_KEY_ENV_VARS to _ENV_VARS_TO_CLEAR with clarifying comment
- Add separate check for 'google' namespace before overwriting
- Remove redundant sys import from mock_graphiti_providers fixture

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: AndyMik90

tests/conftest.py

@@ -44,7 +44,8 @@ def _create_sdk_mock():
 
 # Pre-mock google.generativeai if not installed
 if 'google.generativeai' not in sys.modules:
-    sys.modules['google'] = MagicMock()
+    if 'google' not in sys.modules:
+        sys.modules['google'] = MagicMock()
     sys.modules['google.generativeai'] = MagicMock()
 
 # Add apps/backend directory to path for imports
@@ -167,16 +168,17 @@ def pytest_runtest_setup(item):
 # ENVIRONMENT SAFEGUARDS - Prevent real API calls during tests
 # =============================================================================
 
-# API key environment variables that should be cleared during tests
-_API_KEY_ENV_VARS = [
+# Environment variables that should be cleared during tests to prevent real API calls.
+# Includes API keys, OAuth tokens, and feature flags that enable external services.
+_ENV_VARS_TO_CLEAR = [
     'ANTHROPIC_API_KEY',
     'OPENAI_API_KEY',
     'CLAUDE_CODE_OAUTH_TOKEN',
     'GOOGLE_API_KEY',
     'AZURE_OPENAI_API_KEY',
     'AZURE_OPENAI_ENDPOINT',
     'VOYAGE_API_KEY',
-    'GRAPHITI_ENABLED',
+    'GRAPHITI_ENABLED',  # Feature flag - also cleared to prevent Graphiti initialization
     'LINEAR_API_KEY',
     'GITHUB_TOKEN',
 ]
@@ -194,7 +196,7 @@ def prevent_real_api_calls(monkeypatch):
     The original environment is automatically restored after each test by
     pytest's monkeypatch fixture.
     """
-    for env_var in _API_KEY_ENV_VARS:
+    for env_var in _ENV_VARS_TO_CLEAR:
         monkeypatch.delenv(env_var, raising=False)
 
 
@@ -895,7 +897,6 @@ class MockProviderNotInstalled(Exception):
 
         # Optionally install in sys.modules for module-level mocking
         if install_in_sys_modules:
-            import sys
             sys.modules['graphiti_providers'] = mock_providers
 
         return mock_providers

tests/test_spec_complexity.py

@@ -16,7 +16,6 @@
 import json
 import pytest
 from pathlib import Path
-from unittest.mock import patch, AsyncMock
 
 # SDK modules are pre-mocked by conftest.py before path setup
 # Path to apps/backend is also added by conftest.py

tests/test_spec_pipeline.py

@@ -15,10 +15,11 @@
 """
 
 import json
+import os
 import pytest
 import time
 from pathlib import Path
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
 
 # Import from spec.pipeline - SDK modules are pre-mocked by conftest.py
 from spec.pipeline import SpecOrchestrator, get_specs_dir
@@ -261,8 +262,6 @@ class TestCleanupOrphanedPendingFolders:
 
     def test_removes_empty_pending_folder(self, temp_dir: Path):
         """Removes empty pending folders older than 10 minutes."""
-        import os
-
         with patch('spec.pipeline.init_auto_claude_dir') as mock_init:
             mock_init.return_value = (temp_dir / ".auto-claude", False)
             specs_dir = temp_dir / ".auto-claude" / "specs"
@@ -292,8 +291,6 @@ def test_removes_empty_pending_folder(self, temp_dir: Path):
 
     def test_keeps_folder_with_requirements(self, temp_dir: Path):
         """Keeps pending folder with requirements.json."""
-        import os
-
         with patch('spec.pipeline.init_auto_claude_dir') as mock_init:
             mock_init.return_value = (temp_dir / ".auto-claude", False)
             specs_dir = temp_dir / ".auto-claude" / "specs"
@@ -315,8 +312,6 @@ def test_keeps_folder_with_requirements(self, temp_dir: Path):
 
     def test_keeps_folder_with_spec(self, temp_dir: Path):
         """Keeps pending folder with spec.md."""
-        import os
-
         with patch('spec.pipeline.init_auto_claude_dir') as mock_init:
             mock_init.return_value = (temp_dir / ".auto-claude", False)
             specs_dir = temp_dir / ".auto-claude" / "specs"