From 5860e91520094fa185bf61980828d31ab76e938c Mon Sep 17 00:00:00 2001
From: Anton Ivashkin <ianton@live.com>
Date: Wed, 11 Jun 2025 21:09:44 +0200
Subject: [PATCH] Any location in delta lake catalog

---
 src/Databases/DataLake/ICatalog.cpp | 49 ++++++++++++++++++-----------
 src/Databases/DataLake/ICatalog.h   | 10 ++++--
 2 files changed, 37 insertions(+), 22 deletions(-)

diff --git a/src/Databases/DataLake/ICatalog.cpp b/src/Databases/DataLake/ICatalog.cpp
index 8f611cd8fb21..484cabeda862 100644
--- a/src/Databases/DataLake/ICatalog.cpp
+++ b/src/Databases/DataLake/ICatalog.cpp
@@ -55,29 +55,34 @@ void TableMetadata::setLocation(const std::string & location_)
     if (!with_location)
         throw DB::Exception(DB::ErrorCodes::LOGICAL_ERROR, "Data location was not requested");
 
+    location = location_;
+
+    if (!endpoint.empty())
+        parseLocation();
+}
+
+void TableMetadata::parseLocation() const
+{
     /// Location has format:
     /// s3://<bucket>/path/to/table/data.
     /// We want to split s3://<bucket> and path/to/table/data.
 
-    auto pos = location_.find("://");
+    auto pos = location.find("://");
     if (pos == std::string::npos)
-        throw DB::Exception(DB::ErrorCodes::NOT_IMPLEMENTED, "Unexpected location format: {}", location_);
+        throw DB::Exception(DB::ErrorCodes::NOT_IMPLEMENTED, "Location format incompatible with endpoint override: {}", location);
 
     auto pos_to_bucket = pos + std::strlen("://");
-    auto pos_to_path = location_.substr(pos_to_bucket).find('/');
+    auto pos_to_path = location.substr(pos_to_bucket).find('/');
 
     if (pos_to_path == std::string::npos)
-        throw DB::Exception(DB::ErrorCodes::NOT_IMPLEMENTED, "Unexpected location format: {}", location_);
+        throw DB::Exception(DB::ErrorCodes::NOT_IMPLEMENTED, "Location format incompatible with endpoint override: {}", location);
 
     pos_to_path = pos_to_bucket + pos_to_path;
 
-    location_without_path = location_.substr(0, pos_to_path);
-    path = location_.substr(pos_to_path + 1);
-    bucket = location_.substr(pos_to_bucket, pos_to_path - pos_to_bucket);
+    path = location.substr(pos_to_path + 1);
+    bucket = location.substr(pos_to_bucket, pos_to_path - pos_to_bucket);
 
-    LOG_TEST(getLogger("TableMetadata"),
-             "Parsed location without path: {}, path: {}",
-             location_without_path, path);
+    LOG_TEST(getLogger("TableMetadata"), "Parsed location, path: {}", path);
 }
 
 std::string TableMetadata::getLocation() const
@@ -88,7 +93,7 @@ std::string TableMetadata::getLocation() const
     if (!endpoint.empty())
         return constructLocation(endpoint);
 
-    return std::filesystem::path(location_without_path) / path;
+    return location;
 }
 
 std::string TableMetadata::getLocationWithEndpoint(const std::string & endpoint_) const
@@ -99,24 +104,30 @@ std::string TableMetadata::getLocationWithEndpoint(const std::string & endpoint_
     if (endpoint_.empty())
         throw DB::Exception(DB::ErrorCodes::LOGICAL_ERROR, "Passed endpoint is empty");
 
+    if (path.empty())
+        parseLocation();
+
     return constructLocation(endpoint_);
 }
 
 std::string TableMetadata::constructLocation(const std::string & endpoint_) const
 {
-    std::string location = endpoint_;
-    if (location.ends_with('/'))
-        location.pop_back();
+    std::string location_ = endpoint_;
+    if (location_.ends_with('/'))
+        location_.pop_back();
 
-    if (location.ends_with(bucket))
-        return std::filesystem::path(location) / path / "";
+    if (location_.ends_with(bucket))
+        return std::filesystem::path(location_) / path / "";
     else
-        return std::filesystem::path(location) / bucket / path / "";
+        return std::filesystem::path(location_) / bucket / path / "";
 }
 
 void TableMetadata::setEndpoint(const std::string & endpoint_)
 {
     endpoint = endpoint_;
+
+    if (!endpoint.empty() && path.empty())
+        parseLocation();
 }
 
 void TableMetadata::setSchema(const DB::NamesAndTypesList & schema_)
@@ -163,12 +174,12 @@ std::optional<DataLakeSpecificProperties> TableMetadata::getDataLakeSpecificProp
 
 StorageType TableMetadata::getStorageType() const
 {
-    return parseStorageTypeFromLocation(location_without_path);
+    return parseStorageTypeFromLocation(location);
 }
 
 bool TableMetadata::hasLocation() const
 {
-    return !location_without_path.empty();
+    return !location.empty();
 }
 bool TableMetadata::hasSchema() const
 {
diff --git a/src/Databases/DataLake/ICatalog.h b/src/Databases/DataLake/ICatalog.h
index 8d686fa7ca1b..cc7c645638fb 100644
--- a/src/Databases/DataLake/ICatalog.h
+++ b/src/Databases/DataLake/ICatalog.h
@@ -74,14 +74,15 @@ class TableMetadata
     std::string getReasonWhyTableIsUnreadable() const { return reason_why_table_is_not_readable; }
 
 private:
+    std::string location;
+
     /// Starts with s3://, file://, etc.
     /// For example, `s3://bucket/`
-    std::string location_without_path;
     /// Path to table's data: `/path/to/table/data/`
-    std::string path;
+    mutable std::string path;
     DB::NamesAndTypesList schema;
 
-    std::string bucket;
+    mutable std::string bucket;
     /// Endpoint is set and used in case we have non-AWS storage implementation, for example, Minio.
     /// Also not all catalogs support non-AWS storages.
     std::string endpoint;
@@ -102,6 +103,9 @@ class TableMetadata
     bool with_datalake_specific_metadata = false;
 
     std::string constructLocation(const std::string & endpoint_) const;
+
+    /// Parse location, get bucket and path
+    void parseLocation() const;
 };