Default values for HTTP Client Timeout (#298)

* Set default timeouts

* Use Faraday::RequestOptions

* Pin Faraday version

* Use positional parameter

* Set default timeouts on Ruby 3.2+

* Run timeout tests with Ruby 3.2+ only

* Use Faraday v2.8.1

Author: gcatanese

Gemfile

@@ -4,7 +4,7 @@ source 'https://rubygems.org'
 
 ruby '>= 2.7.0'
 
-gem 'faraday'
+gem 'faraday', '2.8.1'
 
 gem 'activesupport', group: :development
 gem 'bundler', group: :development

lib/adyen/client.rb

@@ -32,7 +32,18 @@ def initialize(ws_user: nil, ws_password: nil, api_key: nil, oauth_token: nil, e
       end
       @mock_service_url_base = mock_service_url_base || "http://localhost:#{mock_port}"
       @live_url_prefix = live_url_prefix
-      @connection_options = connection_options || Faraday::ConnectionOptions.new
+      if RUBY_VERSION >= '3.2'
+        # set default timeouts
+        @connection_options = connection_options || Faraday::ConnectionOptions.new(
+          request: Faraday::RequestOptions.new(
+            open_timeout: 30,
+            timeout: 60
+          )
+        )
+      else
+        @connection_options = connection_options || Faraday::ConnectionOptions.new
+      end
+
       @terminal_region = terminal_region
     end
 

spec/client_spec.rb

@@ -113,10 +113,20 @@
     Adyen::Client.new(env: :test, connection_options: connection_options)
   end
 
+  # test with Ruby 3.2+ only (where Faraday requestOptions timeout is supported)
   it 'initiates a Faraday connection with the provided options' do
-    connection_options = Faraday::ConnectionOptions.new
+    skip "Only runs on Ruby >= 3.2" unless RUBY_VERSION >= '3.2'
+    connection_options = Faraday::ConnectionOptions.new(
+      request: {
+        open_timeout: 5,  
+        timeout: 10      
+      }
+    )
     expect(Faraday::ConnectionOptions).not_to receive(:new)
     client = Adyen::Client.new(api_key: 'api_key', env: :mock, connection_options: connection_options)
+    # verify custom options
+    expect(client.connection_options[:request][:open_timeout]).to eq(5)
+    expect(client.connection_options[:request][:timeout]).to eq(10)
 
     mock_faraday_connection = double(Faraday::Connection)
     client.service_url(@shared_values[:service], 'payments/details', client.checkout.version)
@@ -130,6 +140,14 @@
     client.checkout.payments_api.payments_details(request_body)
   end
 
+  # test with Ruby 3.2+ only (where Faraday requestOptions timeout is supported)
+  it 'initiates a Faraday connection with the expected default timeouts' do
+    skip "Only runs on Ruby >= 3.2" unless RUBY_VERSION >= '3.2'
+    client = Adyen::Client.new(env: :test)
+    expect(client.connection_options[:request][:open_timeout]).to eq(30)
+    expect(client.connection_options[:request][:timeout]).to eq(60)
+  end
+
   it "checks the creation of checkout url" do
     client = Adyen::Client.new(api_key: "api_key", env: :test)
     expect(client.service_url("Checkout", "paymentMethods", "71")).