DB update script should install new preferences, even if no DB update step is needed.

[kainhofer]

The DB update script /install/update.php currently has two tasks: (1) update the database scheme to a new version, and (2) insert new preferences into the database, if the admidio codebase added a new preference.

However, the script currently checks only for a required DB update and does not do anything if no DB update is required. In particular during code development, one sometimes adds a new preference, but does not need a DB update. In that case, the update script will NOT inser the new preference into the database.

The update script should also check for added preferences and insert them, even if no DB update code needs to run.

[Fasse]

I could not reproduce this behavior. In my case a new preference is added although no new database statement was added.

View InstallationUpdate\Service\Update.php line 74 will always be executed.

[Fasse]

Will close this issue. If I have overlook something please comment on this issue.

[kainhofer]

I can still reproduce the issue. Maybe I didn't explain it well enough:
When the database is up-to-date, but a preference is added in install/db_scripts/preferences.php, there is no way to install that new preference into the preferences table, as the updater thinks there is nothing to do.

InstallationUpdate\Service\Update.php line 76 would install the preferences, but the Update::doAdmidioUpdate function is only called in install/update.php if ($getMode === 'update'). Unfortunately, the ($getMode === 'dialog') case checks for version equality and does not offer an update to the user if the DB version and update steps are already at the latest version -> The update.php script cannot be called with the 'update' mode.

[Fasse]

Ah ok, now I understand your issue. You don't have a new version. You still want to add a new preference within the current version.