Moved subfolders have wrong path and show error icon #1801

Author: Fasse

adm_program/installation/db_scripts/update_4_3.xml

@@ -125,5 +125,6 @@
     <step id="1240">UPDATE %PREFIX%_categories SET cat_type = 'EVT' WHERE cat_type = 'DAT'</step>
     <step id="1250">UPDATE %PREFIX%_categories SET cat_org_id = 1 WHERE cat_org_id IS NULL AND cat_name_intern = 'EVENTS'</step>
     <step id="1255">UPDATE %PREFIX%_roles_rights SET ror_table = '%PREFIX%_events' WHERE ror_table = '%PREFIX%_dates'</step>
+    <step id="1260">ComponentUpdateSteps::updateStep43RepairDocumentsPath</step>
     <step>stop</step>
 </update>

adm_program/system/classes/ComponentUpdateSteps.php

@@ -28,6 +28,31 @@ public static function setDatabase(Database $database)
         self::$db = $database;
     }
 
+    /**
+     * Repair the path of the folders
+     */
+    public static function updateStep43RepairDocumentsPath()
+    {
+        $sql = 'SELECT fol_id, fol_name, fol_path
+                  FROM ' . TBL_FOLDERS . '
+                 WHERE fol_fol_id_parent IS NULL ';
+        $rootFolderStatement = self::$db->queryPrepared($sql);
+
+        while ($rowRootFolder = $rootFolderStatement->fetch()) {
+            $rootFolder = new TableFolder(self::$db, $rowRootFolder['fol_id']);
+
+            $sql = 'SELECT fol_id, fol_name, fol_path
+                  FROM ' . TBL_FOLDERS . '
+                 WHERE fol_fol_id_parent = ? -- $rowRootFolder[\'fol_id\']';
+            $folderStatement = self::$db->queryPrepared($sql, array($rowRootFolder['fol_id']));
+
+            while ($row = $folderStatement->fetch()) {
+                $folder = new TableFolder(self::$db, $row['fol_id']);
+                $folder->rename($row['fol_name'], $rootFolder->getValue('fol_path') . '/' . $rowRootFolder['fol_name']);
+            }
+        }
+    }
+
     /**
      * This method removes wrong configured visible roles of category Basic_Data
      */

adm_program/system/classes/TableFolder.php

@@ -682,6 +682,9 @@ public function moveToFolder(string $destFolderUUID)
             $this->setValue('fol_locked', $folder->getValue('fol_locked'));
             $this->save();
 
+            // set new path to all subfolders
+            $this->rename($this->getValue('fol_name'), $folder->getValue('fol_path') . '/' . $folder->getValue('fol_name'));
+
             // adopt the role rights of the new parent folder
             $this->removeRolesOnFolder('folder_view', $this->getViewRolesIds());
             $this->removeRolesOnFolder('folder_upload', $this->getUploadRolesIds());