[BUILD] gh-installdeps.bash tries to install giflib-devel which is already provided #2046
Description
When building inside an aswf-docker image, src/build-scripts/gh-installdeps.bash tries to install giflib and giflib-devel from the configured repositories:
sudo /usr/bin/yum install -y giflib giflib-devel || true
giflib-devel (and thus giflib) is already included in the current images as per the install_yumpackages.sh script.
So giflib-devel is available in all current 2024-2025-2026 images, and I verified that it is already in the 2023 images.
In a typical OSL CI run, I see:
+ sudo /usr/bin/yum install -y giflib giflib-devel
Rocky Linux 8 - AppStream 61 MB/s | 21 MB 00:00
Rocky Linux 8 - BaseOS 74 MB/s | 39 MB 00:00
Rocky Linux 8 - Extras 69 kB/s | 15 kB 00:00
Rocky Linux 8 - PowerTools 13 MB/s | 4.9 MB 00:00
cuda 56 MB/s | 5.8 MB 00:00
Extra Packages for Enterprise Linux 8 - x86_64 7.4 MB/s | 14 MB 00:01
Package giflib-5.1.4-3.el8.x86_64 is already installed.
Package giflib-devel-5.1.4-3.el8.x86_64 is already installed.
Dependencies resolved.
Nothing to do.
Complete!
Checking the upstream repos to do nothing can take a surprising amount of time, and since those repos are not always 100% reliable, maybe best to get rid of that code?