-
Notifications
You must be signed in to change notification settings - Fork 407
Enhance render test output #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add in option to filter out rows based on minimum RMS value. - Add in option JSON, and Markdown options - Cleaned up HTML output.
|
This looks really compelling, @kwokcb, and I'm looking forward to trying this out in the render test suite! |
Was pruning when no error tolerance set.
- Will pack by default (prevous behaviour) - -w <=0 will make it responsive. - Revert -e arg help.
|
I like the added flexibility in the new HTML generation, though when I run the render tests through our usual PDF-generation process, the rendered images seem to be smaller on the page, with an extra white border around them: MaterialXRenderTests_11_22_2025_GitHub.pdf Do you think it would be possible to adjust the default HTML generation to restore the original size of the images on the page, without the additional white border? |
Preserve the image size, border and spacing from original version.
…0 size if use original 512. (122 to 10 MB). and with 256 width to 3MB. This makes easier to store comparisons images in PDF. The idea is to use base64 encoding into JPG and embed it into the html.This also means less disk read / writes for diff image generation. Uses OpenCV + numpy for fast resize. PIL and OpenImage are much slower for this encoding case. JSON storage is about 4mb from 160K when embedding encoded images. Replaced diff with OpenCV + numpy instead of PIL to avoid extra data copies.
|
@jstone-lucasfilm , @ld-kerley : This is about as far as I'm going to take this change for now. (Jonathan, the formatting is as close to the original static tables as possible for html.). |
|
Example run with small change to add hash compares. |
|
I've been playing around with this locally and the Also really liking the markdown output! I did have to install the opencv python module to get the diff to work - the old PIL code doesn't seem to be any sort of fallback to generate the images - but honestly It feels a LOT faster to me using openCV. |
|
It sounds like this work has evolved quite a bit since my last test run, just before the holiday, and I'm looking forward to giving the latest version a try! I have no objection to fully switching from PIL to OpenCV, though I'm curious as to whether we ought to remove the remaining PIL import code from the script, so that we're not depending on two image processing libraries in a single script. Ultimately, our goal is to use OpenImageIO for all of this logic, but we can consider that a future improvement, perhaps timed with the proposed support for Color Moment Hashing in OIIO. |
|
I can remove the PIL code. It is the slowest and also due to type conversion is less accurate and I think won't work with Exr files. Definitely the aim is for consolidating library usage. I was thinking the next step is to decouple analysis tools from here, like we have the ability to pass a verification tool like what is done for the generateShader.py script. The default could be set to OpenImageIO. Analysis data can be computed without comparison this way. E.g hashes can be stored per run, and the similarity test done as needed. The other query beside color moment support is base64 encoding support in OIIO to avoid data copies conversion via numpy. It may be best to keep these as separate tool options as I can see this as being a client side (web) action as well. TBD. |
What does this mean? |
Changes
Output
JSON, Markdown, HTML output
HTML results responsive (fills) vs packed.
Embedding Example
Markdown embedding. This can be stored on any github repo without the original files.
PDF file with reduced images. Straight HTML->PDF save.
Test Results.pdf