Skip to content

feat(app-degree-pages): allow list view including both GR and UGCM c… #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

scott-williams-az
Copy link
Contributor

@scott-williams-az scott-williams-az commented May 15, 2025

…erts

Description

This ticket was to add the ability to show UGCM and GRAD+CERT all within the same set of results

https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1535/@asu/app-degree-pages/index.html?path=/story/program-listing-page--all-with-certificate

Checklist

  • Tests pass for relevant code changes

Important Reminders

Links

@scott-williams-az scott-williams-az requested a review from a team as a code owner May 15, 2025 23:45
@asu-jenkins-devops
Copy link
Collaborator

@scott-williams-az scott-williams-az marked this pull request as draft May 16, 2025 23:56
Comment on lines 81 to 82
// If showing certificates is enabled and the program is graduate,
// include it only if it's a minor or certificate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is now obsolete and can be removed.

@scott-williams-az scott-williams-az marked this pull request as ready for review June 10, 2025 17:09
Copy link
Member

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1535/@asu/app-degree-pages/index.html?path=[…]ry/program-listing-page--grad-with-certificate
Shouldn’t that story have both certs and grad degrees listed? When certs is true, I only see certs records (or at least entries labeled “Certificate” in the Degrees column.

@davidornelas11 davidornelas11 merged commit 5c4d308 into dev Jul 14, 2025
1 check passed
@davidornelas11 davidornelas11 deleted the uds-2006 branch July 14, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants