Skip to content

Commit 415d84d

Browse files
committed
remove --private from cluster
Signed-off-by: Piotr Pawłowski <[email protected]>
1 parent 3d4a71c commit 415d84d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

.github/workflows/build_tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
echo zone=us-central2-b >> $GITHUB_OUTPUT
5353
- name: set tpu-type
5454
id: set-tpu-type
55-
run: |
55+
run: |
5656
echo tpu-type=v4-8 >> $GITHUB_OUTPUT
5757
- name: set location
5858
id: set-location

.github/workflows/cluster_create.yaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ on:
3333
required: true
3434
location:
3535
type: string
36-
required: true
36+
required: trues
3737

3838
env:
3939
# Names must be unique in parallel running tests.
@@ -71,10 +71,8 @@ jobs:
7171
echo $PWD/bin >> "$GITHUB_PATH"
7272
- name: Check xpk installation
7373
run: xpk --help
74-
- name: Create a private Pathways-enabled XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing.
75-
run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}} --private --tpu-type=${{inputs.tpu-type}} --num-slices=2 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=16 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"
76-
- name: Verify the created cluster is private
77-
run: gcloud container clusters describe ${{inputs.cluster-name}} --location=${{inputs.location}} --format="value(privateClusterConfig.enablePrivateNodes)" | grep 'True' || (echo 'The created cluster is not private.' && exit 1)
74+
- name: Create a Pathways-enabled XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing.
75+
run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}} --tpu-type=${{inputs.tpu-type}} --num-slices=2 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=16 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"
7876
- name: Authenticate Docker
7977
run: gcloud auth configure-docker --quiet
8078

0 commit comments

Comments
 (0)