docs deny warnings?

[mightyiam]

Using cargo doc we found a #[warn(rustdoc::broken_intra_doc_links)].

Perhaps it be best if nci would deny warnings, at least by default for the documentation package?

[90-008]

does RUSTDOCFLAGS="-D warnings" not work? but i dunno if that should be the default, i think i'd rather just keep the "default" as the default cargo doc experience...

it maybe interesting to consider sort of global drvConfig and depsDrvConfig options though i guess so something like a "preferences.nix" file can be reused across many projects if setting it is annoying..?

[mightyiam]

does RUSTDOCFLAGS="-D warnings" not work?

Sorry, haven't tried. Should work, right?

From my perspective, there's a difference between the Rust tooling defaults and the Nix Rust tooling defaults. Because in Rust or other languages during development (which is the most frequent use of tools) warnings are printed yet do not fail the build. But when building for release it is best practice (at least in Rust) to have all warnings resolved and I think Nix should follow the release best practice and that's what I tend to do. I use the Nix build to deny warnings. But that's me.

it maybe interesting to consider sort of global drvConfig and depsDrvConfig options

That would be refined ergonomics.

though i guess so something like a "preferences.nix" file can be reused across many projects if setting it is annoying..?

Whatever you mean here sounds difficult to justify, at least to me.

[90-008]

I think Nix should follow the release best practice and that's what I tend to do.

that's fair enough i think, i usually like to just keep the default of the tool since that's more sensible IMO and configure later but it doesn't sound like something i'm against adding just for release builds.

Whatever you mean here sounds difficult to justify, at least to me.

i meant if the global drvConfig options were a thing, perhaps just being able to define a flake input that defines some set of "defaults" and then importing that inside flake-parts would be nice? kind of like how https://github.com/nix-systems/nix-systems works. nci could even automatically just detect the presence of such an input and then use those.

[mightyiam]

i meant if the global drvConfig options were a thing, perhaps just being able to define a flake input that defines some set of "defaults" and then importing that inside flake-parts would be nice? kind of like how https://github.com/nix-systems/nix-systems works. nci could even automatically just detect the presence of such an input and then use those.

I would push back on such fanciness until it seems justified by some compelling use cases though.