Merge pull request #18 from 3scale-sre/fix/creation-deletion-order

Fix dependency declaration

Author: 3scale-robot

hosted-cluster.tf

@@ -102,17 +102,26 @@ resource "helm_release" "hosted_cluster" {
 
   depends_on = [
     aws_iam_openid_connect_provider.oidc,
+    aws_iam_role.worker,
+    aws_iam_role_policy.worker,
     aws_iam_instance_profile.worker,
     aws_iam_role.aws_ebs_csi_driver_controller,
+    aws_iam_role_policy.aws_ebs_csi_driver_controller,
     aws_iam_role.cloud_controller,
+    aws_iam_role_policy.cloud_controller,
     aws_iam_role.cloud_network_config_controller,
+    aws_iam_role_policy.cloud_network_config_controller,
     aws_iam_role.control_plane_operator,
+    aws_iam_role_policy.control_plane_operator,
     aws_iam_role.node_pool,
+    aws_iam_role_policy.node_pool,
     aws_iam_role.openshift_image_registry,
+    aws_iam_role_policy.openshift_image_registry,
     aws_iam_role.openshift_ingress,
-    aws_security_group.worker,
-    aws_route53_zone.private,
+    aws_iam_role_policy.openshift_ingress,
     aws_route53_zone.internal,
+    aws_route53_zone.private,
+    aws_security_group.worker,
     random_bytes.etcd_encryption_key,
     null_resource.cleanup
   ]

security_group.tf

@@ -9,14 +9,6 @@ resource "aws_security_group" "worker" {
   description = "worker security group"
   vpc_id      = var.vpc_id
 
-  # lifecycle {
-  #   ignore_changes = [
-  #     # Ignore changes ingress rules, as they will be modified
-  #     # by openshift controllers
-  #     ingress,
-  #   ]
-  # }
-
   egress {
     cidr_blocks = ["0.0.0.0/0"]
     from_port   = "0"