Skip to content

Commit 5ce000c

Browse files
committed
Don't make project and zone positional args
Hopefully this will prevent the filestore_names list picking up things it shouldn't
1 parent 27ae3b6 commit 5ce000c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

gcpFilestoreBackups/templates/deployment.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ spec:
3434
{{- range .Values.filestoreNames | required "filestoreNames is required" }}
3535
- '{{ . }}'
3636
{{- end }}
37-
- '{{ .Values.project | required "project is required" }}'
38-
- '{{ .Values.zone | required "zone is required" }}'
37+
- --project {{ .Values.project | required "project is required" }}
38+
- --zone {{ .Values.zone | required "zone is required" }}
3939
{{- if .Values.retentionDays }}
40-
- --retention-days '{{ .Values.retentionDays }}'
40+
- --retention-days {{ .Values.retentionDays }}
4141
{{- end }}
4242
{{- if .Values.backupFreqDays }}
43-
- --backup-freq-days '{{ .Values.backupFreqDays }}'
43+
- --backup-freq-days {{ .Values.backupFreqDays }}
4444
{{- end }}
4545
securityContext:
4646
runAsUser: 1000

images/gcp-filestore-backups/gcp-filestore-backups.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,12 +236,12 @@ def main(args):
236236
help="The name of one or more GCP Filestores to backup",
237237
)
238238
parser.add_argument(
239-
"project",
239+
"--project",
240240
type=str,
241241
help="The GCP project the Filestore belongs to",
242242
)
243243
parser.add_argument(
244-
"zone",
244+
"--zone",
245245
type=str,
246246
help="The GCP zone the Filestore is deployed in, e.g. us-central1-b",
247247
)

0 commit comments

Comments
 (0)