Skip to content

Commit 1e95eba

Browse files
committed
fix: github release issue
1 parent 17ca375 commit 1e95eba

File tree

9 files changed

+194
-135
lines changed

9 files changed

+194
-135
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ pluginManagement {
2626
}
2727
plugins {
2828
...
29-
id("me.2bab.seal") version "3.3.0" apply false
29+
id("me.2bab.seal") version "3.4.0" apply false
3030
}
3131
}
3232

README_zh.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ pluginManagement {
2828
}
2929
plugins {
3030
...
31-
id("me.2bab.seal") version "3.3.0" apply false
31+
id("me.2bab.seal") version "3.4.0" apply false
3232
}
3333
}
3434

buildSrc/src/main/kotlin/github-release.gradle.kts

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,10 @@ fun createGithubReleaseTaskInternal(
4646
dryRun.set(false)
4747
generateReleaseNotes.set(false)
4848
releaseAssets.from(
49-
tasks.getByName<Jar>("jar")
50-
.destinationDirectory
51-
.map { it.asFile.listFiles() }
52-
// By right we should put all explicit artifacts,
53-
// however those artifacts does not have APIs to
54-
// be fetched obviously. Thus we put a lot of
55-
// `dependesOn()` below and keep here as a folder.
49+
tasks.getByName<Jar>("jar").archiveFile, // seal-${version}.jar
50+
tasks.getByName<Jar>("sourcesJar").archiveFile, // seal-${version}-sources.jar
51+
tasks.getByName<Jar>("javadocJar").archiveFile, // seal-${version}-javadoc.jar
52+
//tasks.getByName<Sign>("signPluginMavenPublication").outputs, // seal-${version}-asc.jar, seal-${version}-sources-asc.jar, seal-${version}-sources-asc.jar,
5653
)
5754
}
58-
}
59-
60-
task.configure {
61-
dependsOn(":signPluginMavenPublication")
62-
dependsOn(":sourcesJar")
63-
dependsOn(":javadocJar")
64-
dependsOn(":jar")
65-
}
55+
}

functional-test/src/functionalTest/kotlin/SealBaseFunctionTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class SealBaseFunctionTest {
6464
println("assembleFullDebug for [$agpVer]")
6565

6666
GradleRunner.create()
67-
.withGradleVersion("8.1.1")
67+
.withGradleVersion("8.5")
6868
.forwardOutput()
6969
.withArguments("clean", "assembleDebug", "--stacktrace", "--scan")
7070
.withProjectDir(targetProject)

gradle/wrapper/gradle-wrapper.jar

-15.4 KB
Binary file not shown.
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
4+
networkTimeout=10000
5+
validateDistributionUrl=true
46
zipStoreBase=GRADLE_USER_HOME
5-
zipStorePath=wrapper/dists
7+
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)