Skip to content

Commit d50df7c

Browse files
authored
Merge pull request #11 from 1Password/eddy/fix-injection
Improve the way input is processed to avoid command injection
2 parents e28960d + a5debe1 commit d50df7c

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

action.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ inputs:
1010
default: false
1111
runs:
1212
using: composite
13-
steps:
14-
- run: |
15-
export INPUT_UNSET_PREVIOUS=${{ inputs.unset-previous }}
13+
steps:
14+
- shell: bash
15+
env:
16+
INPUT_UNSET_PREVIOUS: ${{ inputs.unset-previous }}
17+
run: |
1618
${{ github.action_path }}/entrypoint.sh
17-
shell: bash

configure/action.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@ inputs:
88
description: Token to authenticate to your 1Password Connect instance
99
runs:
1010
using: composite
11-
steps:
12-
- run: |
13-
export INPUT_CONNECT_HOST=${{ inputs.connect-host }}
14-
export INPUT_CONNECT_TOKEN=${{ inputs.connect-token }}
11+
steps:
12+
- shell: bash
13+
env:
14+
INPUT_CONNECT_HOST: ${{ inputs.connect-host }}
15+
INPUT_CONNECT_TOKEN: ${{ inputs.connect-token }}
16+
run: |
1517
${{ github.action_path }}/entrypoint.sh
16-
shell: bash

0 commit comments

Comments
 (0)