Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Not compute correctly WETH unlock value when WETH is the base #595

@JoaoCampos89

Description

@JoaoCampos89

On Weth related to stable coins, it is normal to use Weth as the base. The getWrapEthStepIfNeeded does not handle these cases when WETH is used as base. My workaround was:

Create an isQuote flag and then on the step:

let wethAmountNeeded = isQuote ? amount.multipliedBy(price) : amount;

Before calling the step we need to check if Weth is the quote or base, could be used the following function:

const isWethQuote = isWeth(quoteToken.symbol.toLowerCase()) ? true : false;

At the moment I recommend warning users about this issue saying Weth is not supported as a base token on the config.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions